From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 23 Nov 2023 07:50:42 +0000 (+1300)
Subject: python: Remove unused parameter ‘samdb’
X-Git-Tag: talloc-2.4.2~313
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eb727331a3702d025036daab619f428eb749c5f3;p=thirdparty%2Fsamba.git

python: Remove unused parameter ‘samdb’

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/upgradeprovisionneeddc.py b/python/samba/tests/upgradeprovisionneeddc.py
index 706b4fa0e88..8cabfa2765e 100644
--- a/python/samba/tests/upgradeprovisionneeddc.py
+++ b/python/samba/tests/upgradeprovisionneeddc.py
@@ -139,7 +139,7 @@ class UpgradeProvisionWithLdbTestCase(TestCaseInTempDir):
                             self.names.policyid)
         shutil.rmtree(dir)
         self.assertFalse(os.path.isdir(dir))
-        update_gpo(self.paths, self.ldbs.sam, self.names)
+        update_gpo(self.paths, self.names)
         self.assertTrue(os.path.isdir(dir))
 
     def test_update_gpo_acl(self):
@@ -150,7 +150,7 @@ class UpgradeProvisionWithLdbTestCase(TestCaseInTempDir):
         os.mkdir(os.path.join(path, self.names.dnsdomain))
         os.mkdir(os.path.join(os.path.join(path, self.names.dnsdomain),
                               "Policies"))
-        update_gpo(self.paths, self.ldbs.sam, self.names)
+        update_gpo(self.paths, self.names)
         shutil.rmtree(path)
         self.paths.sysvol = save
 
diff --git a/python/samba/upgradehelpers.py b/python/samba/upgradehelpers.py
index d19a1b96a63..badfc460189 100644
--- a/python/samba/upgradehelpers.py
+++ b/python/samba/upgradehelpers.py
@@ -451,7 +451,7 @@ def updateOEMInfo(samdb, rootdn):
         samdb.modify(delta)
 
 
-def update_gpo(paths, samdb, names):
+def update_gpo(paths, names):
     """Create missing GPO file object if needed
     """
     dir = getpolicypath(paths.sysvol, names.dnsdomain, names.policyid)
diff --git a/source4/scripting/bin/samba_upgradeprovision b/source4/scripting/bin/samba_upgradeprovision
index ed3abad4d57..18aae6d1423 100755
--- a/source4/scripting/bin/samba_upgradeprovision
+++ b/source4/scripting/bin/samba_upgradeprovision
@@ -1819,7 +1819,7 @@ if __name__ == '__main__':
 
         if opts.full:
             try:
-                update_gpo(paths, ldbs.sam, names)
+                update_gpo(paths, names)
             except ProvisioningError as e:
                 message(ERROR, "The policy for domain controller is missing. "
                             "You should restart upgradeprovision with --full")