From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Fri, 21 Jan 2011 23:35:57 +0000 (+0000)
Subject: Issue #10949: Improved robustness of rotating file handlers.
X-Git-Tag: v3.2.1b1~347^2~50
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eb9d5ad6ba3153d2016d6708e1a3b63ea740e149;p=thirdparty%2FPython%2Fcpython.git

Issue #10949: Improved robustness of rotating file handlers.
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 0d99f469f716..e9dac43f61ef 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -114,6 +114,7 @@ class RotatingFileHandler(BaseRotatingHandler):
         """
         if self.stream:
             self.stream.close()
+            self.stream = None
         if self.backupCount > 0:
             for i in range(self.backupCount - 1, 0, -1):
                 sfn = "%s.%d" % (self.baseFilename, i)
@@ -313,6 +314,7 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
         """
         if self.stream:
             self.stream.close()
+            self.stream = None
         # get the time that this sequence started at and make it a TimeTuple
         t = self.rolloverAt - self.interval
         if self.utc:
diff --git a/Misc/NEWS b/Misc/NEWS
index f6ed01d4e273..4ab4c1cd6613 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -37,6 +37,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #10949: Improved robustness of rotating file handlers.
+
 - Issue #10955: Fix a potential crash when trying to mmap() a file past its
   length.  Initial patch by Ross Lagerwall.