From: Joshua Goins <josh@redstrate.com>
Date: Sat, 4 Mar 2023 03:02:02 +0000 (-0500)
Subject: udev: Don't mark as tablet if device has relative coordinates
X-Git-Tag: v254-rc1~1106
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ebc03f5d7abdb9f600ee02d0299f3d4fad0836dd;p=thirdparty%2Fsystemd.git

udev: Don't mark as tablet if device has relative coordinates

Tablets don't typically have relative coordinates (they are separated on
the kernel device layer). However, some Logitech mice report similar
supported events, so use the existence of EV_REL to determiner whether or
not the device is really a tablet.

Fixes bug introduced by 0855ce67726f87a5a67b4fb536d58e0e4428a248.

Fixes: #26600
---

diff --git a/src/udev/udev-builtin-input_id.c b/src/udev/udev-builtin-input_id.c
index ef656e0504a..540f3905303 100644
--- a/src/udev/udev-builtin-input_id.c
+++ b/src/udev/udev-builtin-input_id.c
@@ -258,7 +258,7 @@ static bool test_pointers(sd_device *dev,
         if (is_tablet && has_pad_buttons)
                 is_tablet_pad = true;
 
-        if (has_pad_buttons && has_wheel) {
+        if (has_pad_buttons && has_wheel && !has_rel_coordinates) {
                 is_tablet = true;
                 is_tablet_pad = true;
         }