From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Sun, 25 Jun 2023 23:11:19 +0000 (+1200)
Subject: s4:kdc: Remove unnecessary NULL check
X-Git-Tag: talloc-2.4.1~178
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ebc27cf32a61d543a1fa2c73ca49e28077904e43;p=thirdparty%2Fsamba.git

s4:kdc: Remove unnecessary NULL check

pac_blobs_add_blob() already checks whether the blob argument is NULL,
and skips adding the blob if so.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 744ecb332a9..9ddeaa51c24 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -2700,14 +2700,12 @@ krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx,
 		goto done;
 	}
 
-	if (device_claims_blob != NULL) {
-		code = pac_blobs_add_blob(&pac_blobs,
-					  mem_ctx,
-					  PAC_TYPE_DEVICE_CLAIMS_INFO,
-					  device_claims_blob);
-		if (code != 0) {
-			goto done;
-		}
+	code = pac_blobs_add_blob(&pac_blobs,
+				  mem_ctx,
+				  PAC_TYPE_DEVICE_CLAIMS_INFO,
+				  device_claims_blob);
+	if (code != 0) {
+		goto done;
 	}
 
 	if (!client_pac_is_trusted || !is_tgs) {