From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 13 Mar 2012 14:18:54 +0000 (+0100)
Subject: s4:librpc/rpc: avoid an unused talloc_reference() from dcerpc_request_send()
X-Git-Tag: tdb-1.2.10~161
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ebcfa61d9f712db8400acd722dfc43c07021c9b0;p=thirdparty%2Fsamba.git

s4:librpc/rpc: avoid an unused talloc_reference() from dcerpc_request_send()

metze
---

diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index 5bcc5f5a076..ebf6f33aa5f 100644
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -1503,10 +1503,7 @@ static struct rpc_request *dcerpc_request_send(TALLOC_CTX *mem_ctx,
 
 	req->opnum = opnum;
 	req->request_data.length = stub_data->length;
-	req->request_data.data = talloc_reference(req, stub_data->data);
-	if (req->request_data.length && req->request_data.data == NULL) {
-		return NULL;
-	}
+	req->request_data.data = stub_data->data;
 
 	DLIST_ADD_END(p->conn->request_queue, req, struct rpc_request *);
 	talloc_set_destructor(req, dcerpc_req_dequeue);