From: Volker Lendecke <vl@samba.org>
Date: Thu, 15 Apr 2021 10:05:34 +0000 (+0200)
Subject: py_security: Avoid casts in py_random_sid()
X-Git-Tag: tevent-0.11.0~1082
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ebea5639cf75f6821bf9fd1a2efcfc086f8b4866;p=thirdparty%2Fsamba.git

py_security: Avoid casts in py_random_sid()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/librpc/ndr/py_security.c b/source4/librpc/ndr/py_security.c
index 96f499614ce..7e260ae2157 100644
--- a/source4/librpc/ndr/py_security.c
+++ b/source4/librpc/ndr/py_security.c
@@ -464,10 +464,12 @@ static PyObject *py_random_sid(PyObject *self,
 {
 	struct dom_sid *sid;
 	PyObject *ret;
-    	char *str = talloc_asprintf(NULL, "S-1-5-21-%u-%u-%u", 
-			(unsigned)generate_random(), 
-			(unsigned)generate_random(), 
-			(unsigned)generate_random());
+	char *str = talloc_asprintf(
+		NULL,
+		"S-1-5-21-%"PRIu32"-%"PRIu32"-%"PRIu32,
+		generate_random(),
+		generate_random(),
+		generate_random());
 
         sid = dom_sid_parse_talloc(NULL, str);
 	talloc_free(str);