From: Nikita Sobolev <mail@sobolevn.me>
Date: Mon, 17 Jul 2023 19:55:40 +0000 (+0300)
Subject: gh-106831: Fix NULL check of d2i_SSL_SESSION() result in _ssl.c (#106832)
X-Git-Tag: v3.13.0a1~1360
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ebf2c56b33553a448da8f60fcd89a622f071b5f4;p=thirdparty%2FPython%2Fcpython.git

gh-106831: Fix NULL check of d2i_SSL_SESSION() result in _ssl.c (#106832)
---

diff --git a/Misc/NEWS.d/next/Library/2023-07-17-21-45-15.gh-issue-106831.RqVq9X.rst b/Misc/NEWS.d/next/Library/2023-07-17-21-45-15.gh-issue-106831.RqVq9X.rst
new file mode 100644
index 000000000000..d3b986268453
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-07-17-21-45-15.gh-issue-106831.RqVq9X.rst
@@ -0,0 +1,2 @@
+Fix potential missing ``NULL`` check of ``d2i_SSL_SESSION`` result in
+``_ssl.c``.
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 0cf4d3e9dc8c..8612b3dd5392 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -2808,7 +2808,7 @@ _ssl_session_dup(SSL_SESSION *session) {
     /* get length */
     slen = i2d_SSL_SESSION(session, NULL);
     if (slen == 0 || slen > 0xFF00) {
-        PyErr_SetString(PyExc_ValueError, "i2d() failed.");
+        PyErr_SetString(PyExc_ValueError, "i2d() failed");
         goto error;
     }
     if ((senc = PyMem_Malloc(slen)) == NULL) {
@@ -2817,12 +2817,13 @@ _ssl_session_dup(SSL_SESSION *session) {
     }
     p = senc;
     if (!i2d_SSL_SESSION(session, &p)) {
-        PyErr_SetString(PyExc_ValueError, "i2d() failed.");
+        PyErr_SetString(PyExc_ValueError, "i2d() failed");
         goto error;
     }
     const_p = senc;
     newsession = d2i_SSL_SESSION(NULL, &const_p, slen);
-    if (session == NULL) {
+    if (newsession == NULL) {
+        PyErr_SetString(PyExc_ValueError, "d2i() failed");
         goto error;
     }
     PyMem_Free(senc);