From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Tue, 17 Jan 2017 20:28:15 +0000 (+0000)
Subject: dbus-spawn: assert impossible returns from read functions don't happen
X-Git-Tag: dbus-1.11.12~17
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ec6cf23718db402fd2c48cf1a76749d999af8fd2;p=thirdparty%2Fdbus.git

dbus-spawn: assert impossible returns from read functions don't happen

This silences -Wswitch-default.

Based on a patch from Thomas Zimmermann.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98191
---

diff --git a/dbus/dbus-spawn.c b/dbus/dbus-spawn.c
index 655bfe92d..3c721d6f5 100644
--- a/dbus/dbus-spawn.c
+++ b/dbus/dbus-spawn.c
@@ -429,6 +429,10 @@ read_data (DBusBabysitter *sitter,
 
     case READ_STATUS_OK:
       break;
+
+    default:
+      _dbus_assert_not_reached ("invalid ReadStatus");
+      break;
     }
   
   if (got == 1)
@@ -453,6 +457,9 @@ read_data (DBusBabysitter *sitter,
                 return r;
               case READ_STATUS_OK:
                 break;
+              default:
+                _dbus_assert_not_reached ("invalid ReadStatus");
+                break;
               }
             
             if (got == 1)
@@ -513,6 +520,9 @@ read_data (DBusBabysitter *sitter,
                 return r;
               case READ_STATUS_OK:
                 break;
+              default:
+                _dbus_assert_not_reached ("invalid ReadStatus");
+                break;
               }
             
             sitter->grandchild_pid = pid;