From: Malcolm Smith <smith@chaquo.com>
Date: Fri, 6 Sep 2024 13:23:55 +0000 (+0100)
Subject: gh-123780: Make test_pkgutil clean up `spam` module (GH-123036)
X-Git-Tag: v3.14.0a1~563
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eca3fe40c251d51964172dd4e6e9c7d0d85d7d4a;p=thirdparty%2FPython%2Fcpython.git

gh-123780: Make test_pkgutil clean up `spam` module (GH-123036)
---

diff --git a/Lib/test/test_pkgutil.py b/Lib/test/test_pkgutil.py
index 20fba87e4ec1..ca6927554b05 100644
--- a/Lib/test/test_pkgutil.py
+++ b/Lib/test/test_pkgutil.py
@@ -624,8 +624,11 @@ class ImportlibMigrationTests(unittest.TestCase):
         mod = type(sys)(name)
         del mod.__spec__
         with CleanImport(name):
-            sys.modules[name] = mod
-            loader = pkgutil.get_loader(name)
+            try:
+                sys.modules[name] = mod
+                loader = pkgutil.get_loader(name)
+            finally:
+                sys.modules.pop(name, None)
         self.assertIsNone(loader)
 
     @ignore_warnings(category=DeprecationWarning)
@@ -634,8 +637,11 @@ class ImportlibMigrationTests(unittest.TestCase):
         mod = type(sys)(name)
         mod.__spec__ = None
         with CleanImport(name):
-            sys.modules[name] = mod
-            loader = pkgutil.get_loader(name)
+            try:
+                sys.modules[name] = mod
+                loader = pkgutil.get_loader(name)
+            finally:
+                sys.modules.pop(name, None)
         self.assertIsNone(loader)
 
     @ignore_warnings(category=DeprecationWarning)