From: Mike Perry <mikeperry-git@fscked.org>
Date: Thu, 22 Nov 2012 00:40:25 +0000 (-0800)
Subject: Note a strange case for SOCKS streams.
X-Git-Tag: tor-0.2.4.8-alpha~18^2~23
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ecaeb505fab12985d314aace49f1277b1b58dc1b;p=thirdparty%2Ftor.git

Note a strange case for SOCKS streams.
---

diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index a654b61711..31ff90093c 100644
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -2181,6 +2181,7 @@ connection_ap_handshake_socks_reply(entry_connection_t *conn, char *reply,
   if (status == SOCKS5_SUCCEEDED) {
     if(!conn->edge_.on_circuit ||
        !CIRCUIT_IS_ORIGIN(conn->edge_.on_circuit)) {
+      // XXX: Weird. We hit this a lot, and yet have no unusable_circs
       log_warn(LD_BUG, "No origin circuit for successful SOCKS stream");
     } else {
       TO_ORIGIN_CIRCUIT(conn->edge_.on_circuit)->any_streams_succeeded = 1;