From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Thu, 8 Dec 2022 20:45:40 +0000 (-0800) Subject: gh-96250: Improve sqlite3 injection attack example (GH-99270) X-Git-Tag: v3.11.2~185 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ecb16d5d63b2299c37c321ea4d8cf6b51c626ac1;p=thirdparty%2FPython%2Fcpython.git gh-96250: Improve sqlite3 injection attack example (GH-99270) (cherry picked from commit 41d4ac9da348ca33056e271d71588b2dc3a6d48d) Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach Co-authored-by: Erlend E. Aasland --- diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index b720ac995c44..e8db6c55c938 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1813,12 +1813,16 @@ How to use placeholders to bind values in SQL queries SQL operations usually need to use values from Python variables. However, beware of using Python's string operations to assemble queries, as they -are vulnerable to `SQL injection attacks`_ (see the `xkcd webcomic -`_ for a humorous example of what can go wrong):: - - # Never do this -- insecure! - symbol = 'RHAT' - cur.execute("SELECT * FROM stocks WHERE symbol = '%s'" % symbol) +are vulnerable to `SQL injection attacks`_. For example, an attacker can simply +close the single quote and inject ``OR TRUE`` to select all rows:: + + >>> # Never do this -- insecure! + >>> symbol = input() + ' OR TRUE; -- + >>> sql = "SELECT * FROM stocks WHERE symbol = '%s'" % symbol + >>> print(sql) + SELECT * FROM stocks WHERE symbol = '' OR TRUE; --' + >>> cur.execute(sql) Instead, use the DB-API's parameter substitution. To insert a variable into a query string, use a placeholder in the string, and substitute the actual values