From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 29 Nov 2004 07:22:57 +0000 (+0000)
Subject: Disallow NDEBUG. It is very stupid.
X-Git-Tag: debian-version-0.0.8+0.0.9rc3-1~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eccfe23a2172717eb9fd1da7f6cb9e629dfd034d;p=thirdparty%2Ftor.git

Disallow NDEBUG. It is very stupid.


svn:r3012
---

diff --git a/src/common/util.h b/src/common/util.h
index e2a7546de1..977425db57 100644
--- a/src/common/util.h
+++ b/src/common/util.h
@@ -24,7 +24,15 @@
  * calling assert() normally.
  */
 #ifdef NDEBUG
-#define tor_assert(expr) do {} while (0)
+/* Nobody should ever want to build with NDEBUG set.  99% of your asserts will
+ * be outside the critical path anyway, so it's silly to disable bugchecking
+ * throughout the entire program just because a few asserts are slowing you
+ * down.  Profile, optimize the critical path, and keep debugging on.
+ *
+ * And I'm not just saying that because some of our asserts check
+ * security-critical properties.
+ */
+#error "Sorry; we don't support building with NDEBUG."
 #else
 #define tor_assert(expr) do {                                 \
  if (!(expr)) {                                               \