From: Victor Julien Date: Mon, 16 Sep 2013 14:22:24 +0000 (+0200) Subject: Coverity 1038135 fix X-Git-Tag: suricata-2.0beta2~369 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ecd5c7573b1adfdf48c42ce8681335ffa47f5700;p=thirdparty%2Fsuricata.git Coverity 1038135 fix Small cleanup in the error handling. The extra null check confused Coverity. --- diff --git a/src/detect-engine-siggroup.c b/src/detect-engine-siggroup.c index 2c21d4d00b..c300cd11c8 100644 --- a/src/detect-engine-siggroup.c +++ b/src/detect-engine-siggroup.c @@ -156,8 +156,7 @@ static SigGroupHead *SigGroupHeadAlloc(DetectEngineCtx *de_ctx, uint32_t size) return sgh; error: - if (sgh != NULL) - SigGroupHeadFree(sgh); + SigGroupHeadFree(sgh); return NULL; }