From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 10 Nov 2025 10:18:00 +0000 (+0900)
Subject: test-ndisc-rs: drop unused verbose flag and log in the debug level
X-Git-Tag: v259-rc1~106
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ecf3c8702d5a4909c274bfad98168427a2e482eb;p=thirdparty%2Fsystemd.git

test-ndisc-rs: drop unused verbose flag and log in the debug level
---

diff --git a/src/libsystemd-network/test-ndisc-rs.c b/src/libsystemd-network/test-ndisc-rs.c
index 71af4c24788..51adc4e6853 100644
--- a/src/libsystemd-network/test-ndisc-rs.c
+++ b/src/libsystemd-network/test-ndisc-rs.c
@@ -22,8 +22,6 @@ static struct ether_addr mac_addr = {
         .ether_addr_octet = {'A', 'B', 'C', '1', '2', '3'}
 };
 
-static bool verbose = false;
-
 static void router_dump(sd_ndisc_router *rt) {
         struct in6_addr addr;
         uint8_t hop_limit;
@@ -188,8 +186,7 @@ static int send_ra(uint8_t flags) {
         assert_se(write(test_fd[1], advertisement, sizeof(advertisement)) ==
                   sizeof(advertisement));
 
-        if (verbose)
-                printf("  sent RA with flag 0x%02x\n", flags);
+        log_debug("%s: Sent RA with flag 0x%02x", __func__, flags);
 
         return 0;
 }
@@ -219,8 +216,7 @@ static void test_callback_ra(sd_ndisc *nd, sd_ndisc_event_t event, void *message
         assert_se(flags == flags_array[idx]);
         idx++;
 
-        if (verbose)
-                printf("  got event 0x%02" PRIx64 "\n", flags);
+        log_debug("%s: Got event 0x%02" PRIx64, __func__, flags);
 
         if (idx < ELEMENTSOF(flags_array)) {
                 send_ra(flags_array[idx]);
@@ -309,13 +305,10 @@ static int send_ra_invalid_domain(uint8_t flags) {
 
         advertisement[5] = flags;
 
-        printf("sizeof(nd_router_advert)=%zu\n", sizeof(struct nd_router_advert));
-
         assert_se(write(test_fd[1], advertisement, sizeof(advertisement)) ==
                   sizeof(advertisement));
 
-        if (verbose)
-                printf("  sent RA with flag 0x%02x\n", flags);
+        log_debug("%s: Sent RA with flag 0x%02x", __func__, flags);
 
         return 0;
 }
@@ -391,8 +384,8 @@ static int send_na(uint32_t flags) {
         ((struct nd_neighbor_advert*) advertisement)->nd_na_flags_reserved = flags;
 
         assert_se(write(test_fd[1], advertisement, sizeof(advertisement)) == sizeof(advertisement));
-        if (verbose)
-                printf("  sent NA with flag 0x%02x\n", flags);
+
+        log_debug("%s: Sent NA with flag 0x%02x", __func__, flags);
 
         return 0;
 }
@@ -422,8 +415,7 @@ static void test_callback_na(sd_ndisc *nd, sd_ndisc_event_t event, void *message
         assert_se(flags == flags_array[idx]);
         idx++;
 
-        if (verbose)
-                printf("  got event 0x%02" PRIx32 "\n", flags);
+        log_debug("%s: Got event 0x%02" PRIx32, __func__, flags);
 
         if (idx < ELEMENTSOF(flags_array)) {
                 send_na(flags_array[idx]);