From: Serhiy Storchaka Date: Sat, 21 Nov 2020 17:17:46 +0000 (+0200) Subject: bpo-42425: Fix possible leak in initialization of errmap for OSError (GH-23446) X-Git-Tag: v3.10.0a3~120 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ed1007c0d74e658d1e6c9b51b12ce7501eb8cbf9;p=thirdparty%2FPython%2Fcpython.git bpo-42425: Fix possible leak in initialization of errmap for OSError (GH-23446) --- diff --git a/Objects/exceptions.c b/Objects/exceptions.c index b14da20db0c4..d4824938a0f5 100644 --- a/Objects/exceptions.c +++ b/Objects/exceptions.c @@ -2547,8 +2547,10 @@ _PyExc_Init(PyThreadState *tstate) do { \ PyObject *_code = PyLong_FromLong(CODE); \ assert(_PyObject_RealIsSubclass(PyExc_ ## TYPE, PyExc_OSError)); \ - if (!_code || PyDict_SetItem(state->errnomap, _code, PyExc_ ## TYPE)) \ + if (!_code || PyDict_SetItem(state->errnomap, _code, PyExc_ ## TYPE)) { \ + Py_XDECREF(_code); \ return _PyStatus_ERR("errmap insertion problem."); \ + } \ Py_DECREF(_code); \ } while (0)