From: Purna Pavan Chandra Aekkaladevi <paekkaladevi@linux.microsoft.com>
Date: Mon, 11 Mar 2024 09:44:02 +0000 (+0000)
Subject: ch_driver: Refactor virCHProcessStart
X-Git-Tag: v10.2.0-rc1~20
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ed12c63f8909f792c356af0dfa358be5b54289a3;p=thirdparty%2Flibvirt.git

ch_driver: Refactor virCHProcessStart

Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkaladevi@linux.microsoft.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c
index 3a15fded1e..250d66bc18 100644
--- a/src/ch/ch_process.c
+++ b/src/ch/ch_process.c
@@ -461,6 +461,34 @@ virCHProcessSetupVcpus(virDomainObj *vm)
     return 0;
 }
 
+static int
+virCHProcessSetup(virDomainObj *vm)
+{
+    virCHDomainObjPrivate *priv = vm->privateData;
+
+    virCHDomainRefreshThreadInfo(vm);
+
+    VIR_DEBUG("Setting emulator tuning/settings");
+    if (virCHProcessSetupEmulatorThreads(vm) < 0)
+        return -1;
+
+    VIR_DEBUG("Setting iothread tuning/settings");
+    if (virCHProcessSetupIOThreads(vm) < 0)
+        return -1;
+
+    VIR_DEBUG("Setting global CPU cgroup (if required)");
+    if (virDomainCgroupSetupGlobalCpuCgroup(vm,
+                                            priv->cgroup) < 0)
+        return -1;
+
+    VIR_DEBUG("Setting vCPU tuning/settings");
+    if (virCHProcessSetupVcpus(vm) < 0)
+        return -1;
+
+    virCHProcessUpdateInfo(vm);
+    return 0;
+}
+
 
 #define PKT_TIMEOUT_MS 500 /* ms */
 
@@ -764,26 +792,9 @@ virCHProcessStart(virCHDriver *driver,
         goto cleanup;
     }
 
-    virCHDomainRefreshThreadInfo(vm);
-
-    VIR_DEBUG("Setting emulator tuning/settings");
-    if (virCHProcessSetupEmulatorThreads(vm) < 0)
-        goto cleanup;
-
-    VIR_DEBUG("Setting iothread tuning/settings");
-    if (virCHProcessSetupIOThreads(vm) < 0)
-        goto cleanup;
-
-    VIR_DEBUG("Setting global CPU cgroup (if required)");
-    if (virDomainCgroupSetupGlobalCpuCgroup(vm,
-                                            priv->cgroup) < 0)
+    if (virCHProcessSetup(vm) < 0)
         goto cleanup;
 
-    VIR_DEBUG("Setting vCPU tuning/settings");
-    if (virCHProcessSetupVcpus(vm) < 0)
-        goto cleanup;
-
-    virCHProcessUpdateInfo(vm);
     virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, reason);
 
     return 0;