From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 25 Sep 2018 10:02:26 +0000 (+0200)
Subject: exec-util: handle putenv() errors
X-Git-Tag: v240~685^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ed689f7894e56024a11bd02327b2bdfce5636dfd;p=thirdparty%2Fsystemd.git

exec-util: handle putenv() errors

Just paranoia, as putenv() can fail and we should catch it, like we
catch all other errors.

Follow-up for #10073
---

diff --git a/src/basic/exec-util.c b/src/basic/exec-util.c
index e8af191104f..169bef11fa9 100644
--- a/src/basic/exec-util.c
+++ b/src/basic/exec-util.c
@@ -102,7 +102,8 @@ static int do_execute(
                 alarm(DIV_ROUND_UP(timeout, USEC_PER_SEC));
 
         STRV_FOREACH(e, envp)
-                putenv(*e);
+                if (putenv(*e) < 0)
+                        return log_error_errno(errno, "Failed to set environment variable: %m");
 
         STRV_FOREACH(path, paths) {
                 _cleanup_free_ char *t = NULL;