From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 21 Jul 2026 10:16:50 +0000 (+0200)
Subject: selftest:Samba3: remove useless 'member' argument and use 'net ads join'
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=edc641fa5e74a976dcccd5f67ca38889a712af1f;p=thirdparty%2Fsamba.git

selftest:Samba3: remove useless 'member' argument and use 'net ads join'

The net_ads_join code path tries to join a domain called 'MEMBER'
and only the fallback to net_rpc_join lets this work at all.

The net_rpc_join code path tries to convert the argument
to a join type.

So use a command real admins will use.

I noticed this as I was wondering about the message:

 ADS join did not work, falling back to RPC...

on the screen when starting the 'clusteredmember'
environment.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 773fc96af14..b99708df1a2 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -664,7 +664,7 @@ sub setup_clusteredmember
 	$cmd .= "RESOLV_CONF=\"$ret->{RESOLV_CONF}\" ";
 	$cmd .= "KRB5_CONFIG=\"$ret->{KRB5_CONFIG}\" ";
 	$cmd .= "SELFTEST_WINBINDD_SOCKET_DIR=\"$ret->{SELFTEST_WINBINDD_SOCKET_DIR}\" ";
-	$cmd .= "$net join $ret->{CONFIGURATION} $dcvars->{DOMAIN} member";
+	$cmd .= "$net ads join $ret->{CONFIGURATION} $dcvars->{DOMAIN}";
 	$cmd .= " -U$dcvars->{USERNAME}\%$dcvars->{PASSWORD}";
 
 	if (system($cmd) != 0) {