From: Jelte Jansen <jelte@isc.org>
Date: Wed, 5 Sep 2012 09:46:21 +0000 (+0200)
Subject: [2160] add comment about Message vars in sync_udp_server
X-Git-Tag: trac2351_base~85^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=edeea1792d69930f2e2aa1d5621e286e868c294b;p=thirdparty%2Fkea.git

[2160] add comment about Message vars in sync_udp_server
---

diff --git a/src/lib/asiodns/sync_udp_server.cc b/src/lib/asiodns/sync_udp_server.cc
index 037074a1c1..0c577f2474 100644
--- a/src/lib/asiodns/sync_udp_server.cc
+++ b/src/lib/asiodns/sync_udp_server.cc
@@ -114,7 +114,12 @@ SyncUDPServer::handleRead(const asio::error_code& ec, const size_t length) {
         return;
     }
 
-    // Make sure the buffers are fresh
+    // Make sure the buffers are fresh.  Note that we don't touch query_
+    // because it's supposed to be cleared in lookup_callback_.  We should
+    // eventually even remove this member variable (and remove it from
+    // the lookup_callback_ interface, but until then, any callback
+    // implementation should be careful that it's the responsibility of
+    // the callback implementation.  See also #2239).
     output_buffer_->clear();
     answer_->clear(isc::dns::Message::RENDER);