From: Ralph Boehme Date: Tue, 9 Jan 2018 09:45:59 +0000 (+0100) Subject: selftest: split a large system invocation line X-Git-Tag: talloc-2.1.11~7 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ee6e0b19f670f370b5643699a194dec774494f74;p=thirdparty%2Fsamba.git selftest: split a large system invocation line Small cleanup for better code readability, no change in behaviour. Signed-off-by: Ralph Boehme Reviewed-by: Andreas Schneider --- diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 73ac1c3a17e..17247274b73 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -2463,7 +2463,11 @@ sub wait_for_start($$$$$) teardown_env($self, $envvars); return 0; } - system(Samba::bindir_path($self, "net") . " $envvars->{CONFIGURATION} cache del IDMAP/SID2XID/S-1-5-32-545"); + + $cmd = Samba::bindir_path($self, "net") . " $envvars->{CONFIGURATION} "; + $cmd .= "cache del IDMAP/SID2XID/S-1-5-32-545"; + system($cmd); + $ret = system("SELFTEST_WINBINDD_SOCKET_DIR=" . $envvars->{SELFTEST_WINBINDD_SOCKET_DIR} . " " . Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545"); if ($ret != 0) { print "Missing \"BUILTIN\\Users\", did net sam createbuiltingroup Users fail?\n";