From: Pavel Filipenský <pfilipensky@samba.org>
Date: Tue, 13 Feb 2024 12:43:50 +0000 (+0100)
Subject: s3:libnet: Sync keytab during libnet_join_create_keytab()
X-Git-Tag: tdb-1.4.11~28
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eeb79875c6edc82bfcaa8ed5d0eade77d64f7e8d;p=thirdparty%2Fsamba.git

s3:libnet: Sync keytab during libnet_join_create_keytab()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=6750

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c
index 490f8ea37ab..d49d54436bb 100644
--- a/source3/libnet/libnet_join.c
+++ b/source3/libnet/libnet_join.c
@@ -859,15 +859,9 @@ static ADS_STATUS libnet_join_set_etypes(TALLOC_CTX *mem_ctx,
 static bool libnet_join_create_keytab(TALLOC_CTX *mem_ctx,
 				      struct libnet_JoinCtx *r)
 {
-	if (!USE_SYSTEM_KEYTAB) {
-		return true;
-	}
+	NTSTATUS ntstatus = sync_pw2keytabs();
 
-	if (ads_keytab_create_default(r->in.ads) != 0) {
-		return false;
-	}
-
-	return true;
+	return NT_STATUS_IS_OK(ntstatus);
 }
 
 /****************************************************************