From: Volker Lendecke <vl@samba.org>
Date: Fri, 22 Jan 2021 18:59:52 +0000 (+0100)
Subject: librpc: Use ndr_syntax_id_buf_string() in dcerpc_binding_set_abstract_syntax()
X-Git-Tag: tevent-0.11.0~1884
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eed1257268e96123d9655527071c00d0ab38f803;p=thirdparty%2Fsamba.git

librpc: Use ndr_syntax_id_buf_string() in dcerpc_binding_set_abstract_syntax()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
---

diff --git a/librpc/rpc/binding.c b/librpc/rpc/binding.c
index 05daccca7df..57ceed012f4 100644
--- a/librpc/rpc/binding.c
+++ b/librpc/rpc/binding.c
@@ -648,7 +648,7 @@ _PUBLIC_ NTSTATUS dcerpc_binding_set_abstract_syntax(struct dcerpc_binding *b,
 						     const struct ndr_syntax_id *syntax)
 {
 	NTSTATUS status;
-	char *s = NULL;
+	struct ndr_syntax_id_buf buf;
 
 	if (syntax == NULL) {
 		status = dcerpc_binding_set_string_option(b, "abstract_syntax", NULL);
@@ -668,18 +668,9 @@ _PUBLIC_ NTSTATUS dcerpc_binding_set_abstract_syntax(struct dcerpc_binding *b,
 		return NT_STATUS_OK;
 	}
 
-	s = ndr_syntax_id_to_string(b, syntax);
-	if (s == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
-
-	status = dcerpc_binding_set_string_option(b, "abstract_syntax", s);
-	TALLOC_FREE(s);
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
-	return NT_STATUS_OK;
+	status = dcerpc_binding_set_string_option(
+		b, "abstract_syntax", ndr_syntax_id_buf_string(syntax, &buf));
+	return status;
 }
 
 _PUBLIC_ const char *dcerpc_binding_get_string_option(const struct dcerpc_binding *b,