From: James Coglan <james@neighbourhood.ie>
Date: Tue, 11 Jun 2024 13:44:26 +0000 (+0100)
Subject: resolved: tests for dns_packet_equal()
X-Git-Tag: v257-rc1~844^2~22
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eedf263bd0c9afe49d2ed03667e0d1f028fc3092;p=thirdparty%2Fsystemd.git

resolved: tests for dns_packet_equal()
---

diff --git a/src/resolve/test-dns-packet-extract.c b/src/resolve/test-dns-packet-extract.c
index 9cca1c2981f..e1cbb1ca71c 100644
--- a/src/resolve/test-dns-packet-extract.c
+++ b/src/resolve/test-dns-packet-extract.c
@@ -3784,4 +3784,56 @@ TEST(packet_reply_svcb_service_mode_bad_ipv6hint) {
         ASSERT_EQ(dns_answer_size(packet->answer), 0u);
 }
 
+/* ================================================================
+ * dns_packet_equal()
+ * ================================================================ */
+
+TEST(packet_equal_match) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *p1 = NULL, *p2 = NULL;
+
+        ASSERT_OK(dns_packet_new(&p1, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(p1);
+        dns_packet_truncate(p1, 0);
+
+        ASSERT_OK(dns_packet_new(&p2, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(p2);
+        dns_packet_truncate(p2, 0);
+
+        const uint8_t data[] = {
+                0x00, 0x2a,     BIT_QR | BIT_AA, DNS_RCODE_SUCCESS,
+                0x00, 0x00,     0x00, 0x02,     0x00, 0x00,     0x00, 0x00
+        };
+
+        ASSERT_OK(dns_packet_append_blob(p1, data, sizeof(data), NULL));
+        ASSERT_OK(dns_packet_append_blob(p2, data, sizeof(data), NULL));
+        ASSERT_TRUE(dns_packet_equal(p1, p2));
+}
+
+TEST(packet_equal_no_match) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *p1 = NULL, *p2 = NULL;
+
+        ASSERT_OK(dns_packet_new(&p1, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(p1);
+        dns_packet_truncate(p1, 0);
+
+        const uint8_t data1[] = {
+                0x00, 0x2a,     BIT_QR | BIT_AA, DNS_RCODE_SUCCESS,
+                0x00, 0x00,     0x00, 0x02,     0x00, 0x00,     0x00, 0x00
+        };
+
+        ASSERT_OK(dns_packet_append_blob(p1, data1, sizeof(data1), NULL));
+
+        ASSERT_OK(dns_packet_new(&p2, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(p2);
+        dns_packet_truncate(p2, 0);
+
+        const uint8_t data2[] = {
+                0x00, 0x2a,     BIT_QR | BIT_AA, DNS_RCODE_SUCCESS,
+                0x00, 0x00,     0x00, 0x02,     0x00, 0x00,     0x00, 0x01
+        };
+
+        ASSERT_OK(dns_packet_append_blob(p2, data2, sizeof(data2), NULL));
+        ASSERT_FALSE(dns_packet_equal(p1, p2));
+}
+
 DEFINE_TEST_MAIN(LOG_DEBUG)