From: Aram Sargsyan <aram@isc.org>
Date: Tue, 3 Jan 2023 13:34:58 +0000 (+0000)
Subject: Fix an error path bug in rpz.c:update_nodes()
X-Git-Tag: v9.19.9~50^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ef4f15d2d1f2b97c1443c3dc0422765bdc06ef9e;p=thirdparty%2Fbind9.git

Fix an error path bug in rpz.c:update_nodes()

When dns_db_createiterator() fails, 'updbit' should not be destroyed
for obvious reasons, i.e. it is NULL.
---

diff --git a/lib/dns/rpz.c b/lib/dns/rpz.c
index 94ee75bf523..70e341a153e 100644
--- a/lib/dns/rpz.c
+++ b/lib/dns/rpz.c
@@ -1718,7 +1718,7 @@ update_nodes(dns_rpz_zone_t *rpz, isc_ht_t *newnodes) {
 			      DNS_LOGMODULE_MASTER, ISC_LOG_ERROR,
 			      "rpz: %s: failed to create DB iterator - %s",
 			      domain, isc_result_totext(result));
-		goto cleanup;
+		return (result);
 	}
 
 	result = dns_dbiterator_first(updbit);