From: Volker Lendecke <vl@samba.org>
Date: Wed, 28 Mar 2018 12:27:08 +0000 (-0500)
Subject: libads: Fix CID 1349423 Resource leak
X-Git-Tag: talloc-2.1.13~116
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=efa66c9ebf519dfaf194220652b3e5e01c303fb6;p=thirdparty%2Fsamba.git

libads: Fix CID 1349423 Resource leak

get_sorted_dc_list should already take care, but this way it's safer

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 29 03:45:00 CEST 2018 on sn-devel-144
---

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index 70166f2f594..f9463043cc8 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -412,7 +412,7 @@ static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const char *sitename,
 				     const char *realm)
 {
 	int count;
-	struct ip_service *ip_list;
+	struct ip_service *ip_list = NULL;
 	NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
 
 	DEBUG(6, ("resolve_and_ping_dns: (cldap) looking for realm '%s'\n",
@@ -421,6 +421,7 @@ static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const char *sitename,
 	status = get_sorted_dc_list(realm, sitename, &ip_list, &count,
 				    true);
 	if (!NT_STATUS_IS_OK(status)) {
+		SAFE_FREE(ip_list);
 		return status;
 	}