From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 19 Jun 2019 12:14:59 +0000 (-0400)
Subject: Further clarify our clarification about the type of POSINT
X-Git-Tag: tor-0.4.2.1-alpha~131^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f0074372928829835adf6aa2dde9af712097c7c0;p=thirdparty%2Ftor.git

Further clarify our clarification about the type of POSINT
---

diff --git a/src/lib/conf/conftypes.h b/src/lib/conf/conftypes.h
index b03234b62c..e66ab3d5aa 100644
--- a/src/lib/conf/conftypes.h
+++ b/src/lib/conf/conftypes.h
@@ -73,10 +73,10 @@ typedef enum config_type_t {
 typedef union {
   char **STRING;
   char **FILENAME;
-  int *POSINT; /* yes, really: Even though the confparse type is called
-                * "POSINT", it still uses the C int type -- it just enforces
-                * that the values are in range [0,INT_MAX].
-              */
+  int *POSINT; /* yes, this is really an int, and not an unsigned int.  For
+                * historical reasons, many configuration values are restricted
+                * to the range [0,INT_MAX], and stored in signed ints.
+                */
   uint64_t *UINT64;
   int *INT;
   int *INTERVAL;