From: Lubomir Rintel <lkundrak@v3.sk>
Date: Mon, 24 Jun 2019 17:23:13 +0000 (+0200)
Subject: udevd: fix a reversed conditional on global property set
X-Git-Tag: v243-rc1~242
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f053fc337e2cbb99d83fea156324b26a31171de0;p=thirdparty%2Fsystemd.git

udevd: fix a reversed conditional on global property set

  # udevadm control --property=HELLO=WORLD
  Received udev control message (ENV), unsetting 'HELLO'
  # udevadm control --property=HELLO=
  Received udev control message (ENV), setting 'HELLO='

Oh no, it's busted. Let's try removing this one little negation real quick
to see if it helps...

  # udevadm control --property=HELLO=WORLD
  Received udev control message (ENV), setting 'HELLO=WORLD'
  # udevadm control --property=HELLO=
  Received udev control message (ENV), unsetting 'HELLO'

Feels much better now.
---

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 8e7402fd875..25a1095ff4c 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -1052,7 +1052,7 @@ static int on_ctrl_msg(struct udev_ctrl *uctrl, enum udev_ctrl_msg_type type, co
                 }
 
                 eq++;
-                if (!isempty(eq)) {
+                if (isempty(eq)) {
                         log_debug("Received udev control message (ENV), unsetting '%s'", key);
 
                         r = hashmap_put(manager->properties, key, NULL);