From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Wed, 24 Nov 2021 20:13:44 +0000 (+0000)
Subject: coredump: always log on failure in parse_core()
X-Git-Tag: v250-rc1~108^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f05b5cddfb2886ab95241d64f97ab039440afe96;p=thirdparty%2Fsystemd.git

coredump: always log on failure in parse_core()
---

diff --git a/src/coredump/stacktrace.c b/src/coredump/stacktrace.c
index dc8a71ac7c8..b430f2b3eae 100644
--- a/src/coredump/stacktrace.c
+++ b/src/coredump/stacktrace.c
@@ -367,12 +367,12 @@ static int parse_core(int fd, const char *executable, char **ret, JsonVariant **
         assert(fd >= 0);
 
         if (lseek(fd, 0, SEEK_SET) == (off_t) -1)
-                return -errno;
+                return log_warning_errno(errno, "Failed to seek to beginning of the core file: %m");
 
         if (ret) {
                 c.f = open_memstream_unlocked(&buf, &sz);
                 if (!c.f)
-                        return -ENOMEM;
+                        return log_oom();
         }
 
         elf_version(EV_CURRENT);