From: Ondřej Surý <ondrej@isc.org>
Date: Wed, 6 May 2026 08:12:35 +0000 (+0200)
Subject: Pass empty string instead of NULL to ns_client_dumpmessage()
X-Git-Tag: v9.21.22~2^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f060971f84ebdaa3814f3dbfb0345c48f749b47d;p=thirdparty%2Fbind9.git

Pass empty string instead of NULL to ns_client_dumpmessage()

The two new call sites added by the CLASS-validation work passed NULL
as the reason, but ns_client_dumpmessage() bails out early on a NULL
reason — so the message dump never happened. The intent was to dump
the message and let the follow-up ns_client_log() carry the reason
text, so pass "" to suppress the prefix without short-circuiting the
dump.
---

diff --git a/lib/ns/client.c b/lib/ns/client.c
index 7a48d613af3..7d2f77e6462 100644
--- a/lib/ns/client.c
+++ b/lib/ns/client.c
@@ -2139,7 +2139,7 @@ ns_client_request(isc_nmhandle_t *handle, isc_result_t eresult,
 	default:
 		dns_rdataclass_format(client->message->rdclass, classbuf,
 				      sizeof(classbuf));
-		ns_client_dumpmessage(client, NULL);
+		ns_client_dumpmessage(client, "");
 		ns_client_log(client, NS_LOGCATEGORY_CLIENT,
 			      NS_LOGMODULE_CLIENT, ISC_LOG_DEBUG(1),
 			      "invalid message class: %s", classbuf);
@@ -2238,7 +2238,7 @@ ns_client_request_continue(void *arg) {
 			dns_rdataclass_format(client->message->rdclass,
 					      classname, sizeof(classname));
 
-			ns_client_dumpmessage(client, NULL);
+			ns_client_dumpmessage(client, "");
 			ns_client_log(client, NS_LOGCATEGORY_CLIENT,
 				      NS_LOGMODULE_CLIENT, ISC_LOG_DEBUG(1),
 				      "no matching view in class '%s'",