From: Artem Boldariev <artem@boldariev.com>
Date: Tue, 5 Apr 2022 10:33:40 +0000 (+0300)
Subject: Change X509_STORE_up_ref() shim return value
X-Git-Tag: v9.19.0~14^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f0ac4c47b04724c1b4ffae33a1809554b1f56b91;p=thirdparty%2Fbind9.git

Change X509_STORE_up_ref() shim return value

X509_STORE_up_ref() must return 1 on success, while the previous
implementation would return the references count. This commit fixes
that.
---

diff --git a/lib/isc/openssl_shim.c b/lib/isc/openssl_shim.c
index 1dcc921f01e..3d6cbeed893 100644
--- a/lib/isc/openssl_shim.c
+++ b/lib/isc/openssl_shim.c
@@ -174,7 +174,7 @@ OPENSSL_cleanup(void) {
 
 int
 X509_STORE_up_ref(X509_STORE *store) {
-	return (CRYPTO_add(&store->references, 1, CRYPTO_LOCK_X509_STORE));
+	return (CRYPTO_add(&store->references, 1, CRYPTO_LOCK_X509_STORE) > 0);
 }
 
 #endif /* !HAVE_OPENSSL_CLEANUP */