From: Damien Lespiau <damien.lespiau@intel.com>
Date: Fri, 9 Oct 2015 10:22:54 +0000 (+0100)
Subject: parsemail: Don't catch exceptions when saving patches and comments
X-Git-Tag: v1.1.0~198
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f0b88868e26bd24c1676caefe389d4865ede7089;p=thirdparty%2Fpatchwork.git

parsemail: Don't catch exceptions when saving patches and comments

We'd like to know when those operations fail in production so we can at
least inspect what happened through the email send to settings.ADMINS in
main().

Catching those exceptions early prevents that.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Acked-by: Stephen Finucane <stephen.finucane@intel.com>
---

diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py
index 84ab6859..c15564e9 100755
--- a/patchwork/bin/parsemail.py
+++ b/patchwork/bin/parsemail.py
@@ -384,10 +384,7 @@ def parse_mail(mail):
         patch.state = get_state(mail.get('X-Patchwork-State', '').strip())
         patch.delegate = get_delegate(
                 mail.get('X-Patchwork-Delegate', '').strip())
-        try:
-            patch.save()
-        except Exception, ex:
-            print str(ex)
+        patch.save()
 
     if comment:
         if save_required:
@@ -397,10 +394,7 @@ def parse_mail(mail):
             comment.patch = patch
         comment.submitter = author
         comment.msgid = msgid
-        try:
-            comment.save()
-        except Exception, ex:
-            print str(ex)
+        comment.save()
 
     return 0