From: Garming Sam <garming@catalyst.net.nz>
Date: Wed, 7 Mar 2018 00:27:20 +0000 (+1300)
Subject: ldb_tdb: Remove unnecessary call to tdb_get_seqnum
X-Git-Tag: talloc-2.1.12~238
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f0bebcc4e046ee668c83030c432f99586a17207c;p=thirdparty%2Fsamba.git

ldb_tdb: Remove unnecessary call to tdb_get_seqnum

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar  8 14:14:37 CET 2018 on sn-devel-144
---

diff --git a/lib/ldb/ldb_tdb/ldb_tdb.c b/lib/ldb/ldb_tdb/ldb_tdb.c
index 4f1c241e96a..9c8c77155c4 100644
--- a/lib/ldb/ldb_tdb/ldb_tdb.c
+++ b/lib/ldb/ldb_tdb/ldb_tdb.c
@@ -1799,11 +1799,12 @@ static const char * ltdb_tdb_name(struct ltdb_private *ltdb)
 
 static bool ltdb_tdb_changed(struct ltdb_private *ltdb)
 {
-	bool ret = (tdb_get_seqnum(ltdb->tdb) != ltdb->tdb_seqnum);
+	int seq = tdb_get_seqnum(ltdb->tdb);
+	bool has_changed = (seq != ltdb->tdb_seqnum);
 
-	ltdb->tdb_seqnum = tdb_get_seqnum(ltdb->tdb);
+	ltdb->tdb_seqnum = seq;
 
-	return ret;
+	return has_changed;
 }
 
 static const struct kv_db_ops key_value_ops = {