From: Samet YASLAN Date: Wed, 28 Dec 2022 21:31:43 +0000 (+0100) Subject: gh-100585: Fixed a bug where importlib.resources.as_file was leaving file pointers... X-Git-Tag: v3.12.0a4~99 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f10f503b24a35a43910a632ee50c7568bedd6664;p=thirdparty%2FPython%2Fcpython.git gh-100585: Fixed a bug where importlib.resources.as_file was leaving file pointers open (GH-100586) * gh-100585: Fixed open fp bug in the imporlib module * Added news for gh-100585 --- diff --git a/Lib/importlib/resources/_common.py b/Lib/importlib/resources/_common.py index 8c0be7ee547e..92a37e2c12b8 100644 --- a/Lib/importlib/resources/_common.py +++ b/Lib/importlib/resources/_common.py @@ -155,5 +155,5 @@ def _write_contents(target, source): for item in source.iterdir(): _write_contents(child, item) else: - child.open('wb').write(source.read_bytes()) + child.write_bytes(source.read_bytes()) return child diff --git a/Misc/NEWS.d/next/Library/2022-12-28-17-38-39.gh-issue-100585.BiiTlG.rst b/Misc/NEWS.d/next/Library/2022-12-28-17-38-39.gh-issue-100585.BiiTlG.rst new file mode 100644 index 000000000000..0bf33b8bdd02 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-12-28-17-38-39.gh-issue-100585.BiiTlG.rst @@ -0,0 +1 @@ +Fixed a bug where importlib.resources.as_file was leaving file pointers open