From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Mon, 13 Aug 2012 18:17:20 +0000 (+0200)
Subject: s4:kdc/wdc-samba4.c - fix user logins on specific workstations
X-Git-Tag: samba-4.0.0beta6~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f11a1a4a0796c8e77eee721f1ed1406b01e2b007;p=thirdparty%2Fsamba.git

s4:kdc/wdc-samba4.c - fix user logins on specific workstations

The decrement operation has been missing.

Problem found by Mohammad Ebrahim Abravi <lamp.mia@gmail.com>

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/wdc-samba4.c b/source4/kdc/wdc-samba4.c
index 70e849ccb74..2f4945c312c 100644
--- a/source4/kdc/wdc-samba4.c
+++ b/source4/kdc/wdc-samba4.c
@@ -187,14 +187,15 @@ static char *get_netbios_name(TALLOC_CTX *mem_ctx, HostAddresses *addrs)
 		}
 	}
 
-	if (nb_name == NULL) {
+	if ((nb_name == NULL) || (nb_name[0] == '\0')) {
 		return NULL;
 	}
 
 	/* Strip space padding */
-	i = strlen(nb_name) - 1;
-	while (i > 0 && nb_name[i] == ' ') {
-		nb_name[i] = '\0';
+	for (len = strlen(nb_name) - 1;
+	     (len > 0) && (nb_name[len] == ' ');
+	     --len) {
+		nb_name[len] = '\0';
 	}
 
 	return nb_name;