From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 26 Nov 2019 13:14:54 +0000 (+0100)
Subject: qemu: blockjob: Log blockjobs which are dropped when untracked by qemu
X-Git-Tag: v5.10.0-rc2~11
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f15d4cb1c869ff691b2d6cddbe8463be28d526e1;p=thirdparty%2Flibvirt.git

qemu: blockjob: Log blockjobs which are dropped when untracked by qemu

Since we don't know what happened to the job we can't do much about it
but we can at least log that this happened.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
---

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 818e36435c..b83d681f06 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -501,8 +501,10 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver,
 
     /* remove data for job which qemu didn't report (the algorithm is
      * inefficient, but the possibility of such jobs is very low */
-    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL)))
+    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL))) {
+        VIR_WARN("dropping blockjob '%s' untracked by qemu", job->name);
         qemuBlockJobUnregister(job, vm);
+    }
 
     ret = 0;