From: teor <teor@torproject.org>
Date: Mon, 4 Mar 2019 01:22:02 +0000 (+1000)
Subject: doc: Fix an incorrect comment about calling FreeLibrary() on Windows
X-Git-Tag: tor-0.4.0.3-alpha~15^2^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f186f21a4efb9dafe2c29f850126d509079c0c37;p=thirdparty%2Ftor.git

doc: Fix an incorrect comment about calling FreeLibrary() on Windows

There's an incorrect comment in compat_time.c that suggests we call
FreeLibrary() before we're done using the library's functions.
See 29642 for background.

Closes ticket 29643.
---

diff --git a/src/lib/time/compat_time.c b/src/lib/time/compat_time.c
index 33e077a587..c6625c7806 100644
--- a/src/lib/time/compat_time.c
+++ b/src/lib/time/compat_time.c
@@ -522,7 +522,9 @@ monotime_init_internal(void)
     GetTickCount64_fn = (GetTickCount64_fn_t)
       GetProcAddress(h, "GetTickCount64");
   }
-  // FreeLibrary(h) ?
+  // We can't call FreeLibrary(h) here, because freeing the handle may
+  // unload the library, and cause future calls to GetTickCount64_fn()
+  // to fail. See 29642 for details.
 }
 
 void