From: BY-jk <BY-jk@users.noreply.github.com>
Date: Fri, 30 May 2014 19:11:19 +0000 (+0200)
Subject: Uninitialized local variable
X-Git-Tag: rel_0_9_5~14^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f1c2bb4afbe32ff8eb40dba42fee464f536affec;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Uninitialized local variable

implicit_return_defaults is not properly initialized. I am implementing a MERGE statement (inherits from Executable and ClauseElement) that is neither INSERT nor UPDATE. This causes access to the uninitialized variable in line 1979.
---

diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index a7465204a6..44fbb77df2 100644
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -1968,6 +1968,7 @@ class SQLCompiler(Compiled):
                                 self.dialect.implicit_returning and \
                                 stmt.table.implicit_returning
 
+        implicit_return_defaults = False
         if self.isinsert:
             implicit_return_defaults = implicit_returning and stmt._return_defaults
         elif self.isupdate: