From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Mon, 19 Jan 2026 18:10:42 +0000 (+0100)
Subject: lib/pager: Remove struct field `no_stdin`
X-Git-Tag: v2.43-devel~136^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f1ecf7b35caf7d136586d7c8e4cb13e3e49e7943;p=thirdparty%2Futil-linux.git

lib/pager: Remove struct field `no_stdin`

The struct field `no_stdin` is always false, since it's never
initialized and only eventually reset to false when the whole
`pager_process` is reset to 0 with a `memset` call.

Since pager is supposed to read from stdin, this feature is not needed.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---

diff --git a/lib/pager.c b/lib/pager.c
index b753c5f6d..b0520abcd 100644
--- a/lib/pager.c
+++ b/lib/pager.c
@@ -40,8 +40,6 @@ struct child_process {
 	struct sigaction orig_sigterm;
 	struct sigaction orig_sigquit;
 	struct sigaction orig_sigpipe;
-
-	bool no_stdin;
 };
 static struct child_process pager_process;
 
@@ -78,7 +76,7 @@ static int start_command(struct child_process *cmd)
 	 * In case of errors we must keep the promise to close FD
 	 * that has been passed in via ->in.
 	 */
-	need_in = !cmd->no_stdin && cmd->in < 0;
+	need_in = cmd->in < 0;
 	if (need_in) {
 		if (pipe(fdin) < 0)
 			return -1;