From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 2 Sep 2022 16:35:03 +0000 (+0200)
Subject: log: don't attempt to duplicate closed fd
X-Git-Tag: v252-rc1~270
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f1ee066840eea748ad4074ac2bc859bb897953b9;p=thirdparty%2Fsystemd.git

log: don't attempt to duplicate closed fd

if the console fd is not open we shouldn#t try to move it out of the 0…2
range.

Fixes: #24535
Alternative-for: #24537
---

diff --git a/src/basic/log.c b/src/basic/log.c
index cac17a76f4d..c5e16d669b0 100644
--- a/src/basic/log.c
+++ b/src/basic/log.c
@@ -1460,7 +1460,7 @@ int log_dup_console(void) {
         /* Duplicate the fd we use for fd logging if it's < 3 and use the copy from now on. This call is useful
          * whenever we want to continue logging through the original fd, but want to rearrange stderr. */
 
-        if (console_fd >= 3)
+        if (console_fd < 0 || console_fd >= 3)
                 return 0;
 
         copy = fcntl(console_fd, F_DUPFD_CLOEXEC, 3);