From: Evgeny Vereshchagin Date: Thu, 26 May 2022 16:16:22 +0000 (+0000) Subject: tests: link tests using fabs against libm explicitly X-Git-Tag: v252-rc1~910 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f232c83c7257e08ccbeafc994c90e38515d04c6e;p=thirdparty%2Fsystemd.git tests: link tests using fabs against libm explicitly Some compiler wrappers like honggfuzz pass -fno-builtin explicitly and because of that the tests where fabs is used fail to compile with something like ``` FAILED: test-bus-marshal ... /usr/bin/ld: test-bus-marshal.p/src_libsystemd_sd-bus_test-bus-marshal.c.o: undefined reference to symbol 'fabs@@GLIBC_2.2.5' /usr/bin/ld: /usr/lib64/libm.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Fun fact: it took honggfuzz less than a minute to discover https://github.com/advisories/GHSA-gmc7-pqv9-966m used by systemd to compress/descompress some stuff. --- diff --git a/src/libsystemd/meson.build b/src/libsystemd/meson.build index 8a03890d8b5..c3eef87b840 100644 --- a/src/libsystemd/meson.build +++ b/src/libsystemd/meson.build @@ -222,7 +222,8 @@ tests += [ libglib, libgobject, libgio, - libdbus]], + libdbus, + libm]], [files('sd-bus/test-bus-signature.c'), [], diff --git a/src/test/meson.build b/src/test/meson.build index 74da544a46e..d9304d538b0 100644 --- a/src/test/meson.build +++ b/src/test/meson.build @@ -211,7 +211,9 @@ tests += [ [files('test-mkdir.c')], - [files('test-json.c')], + [files('test-json.c'), + [], + [libm]], [files('test-modhex.c')], @@ -275,7 +277,9 @@ tests += [ [files('test-parse-helpers.c')], - [files('test-parse-util.c')], + [files('test-parse-util.c'), + [], + [libm]], [files('test-sysctl-util.c')],