From: Simo Sorce <idra@samba.org> 
Date: Sat, 11 Aug 2001 16:34:11 +0000 (+0000)
Subject: Without this become_root()/unbecome_root() pair I was not able to login
X-Git-Tag: samba-2.2.5pre1~1555^2~166
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f25a5dab6012ebbe83435b06650d6ab92432760a;p=thirdparty%2Fsamba.git

Without this become_root()/unbecome_root() pair I was not able to login
when samba acting as a PDC.
I also removed a pdb_free_sam(sampass), because it sampass was never
initialized before...

Please abartlet can you check this patch is ok?
I feel like this was a bad check-in
---

diff --git a/source/rpc_server/srv_netlog_nt.c b/source/rpc_server/srv_netlog_nt.c
index 385fec5862c..b7e1d3538db 100644
--- a/source/rpc_server/srv_netlog_nt.c
+++ b/source/rpc_server/srv_netlog_nt.c
@@ -563,7 +563,9 @@ static uint32 _net_logon_any(NET_ID_INFO_CTR *ctr, char *user, char *domain, cha
 		return NT_STATUS_INVALID_INFO_CLASS;
 	} /* end switch */
 	
+	become_root();
 	nt_status = check_password(&user_info, &server_info);
+	unbecome_root();
 
 	DEBUG(5, ("_net_logon_any: exited with status %d\n", nt_status));
 
@@ -652,10 +654,8 @@ uint32 _net_sam_logon(pipes_struct *p, NET_Q_SAM_LOGON *q_u, NET_R_SAM_LOGON *r_
 
 	/* Check account and password */
     
-	if (status != NT_STATUS_NOPROBLEMO) {
-		pdb_free_sam(sampass);
+	if (status != NT_STATUS_NOPROBLEMO)
 		return status;
-	}
 
 	pdb_init_sam(&sampass);