From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 4 Jul 2022 02:23:33 +0000 (+0900)
Subject: resolve: mdns_packet_extract_matching_rrs() may return 0
X-Git-Tag: v252-rc1~566^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f2605af1f2e770818bbc6bad2561acdbd25a38ad;p=thirdparty%2Fsystemd.git

resolve: mdns_packet_extract_matching_rrs() may return 0

Fixes the following assertion:
---
Assertion 'r > 0' failed at src/resolve/resolved-mdns.c:180, function mdns_do_tiebreak(). Aborting.
---
---

diff --git a/src/resolve/resolved-mdns.c b/src/resolve/resolved-mdns.c
index 0a66bccba3e..2ad3a792da5 100644
--- a/src/resolve/resolved-mdns.c
+++ b/src/resolve/resolved-mdns.c
@@ -177,8 +177,6 @@ static int mdns_do_tiebreak(DnsResourceKey *key, DnsAnswer *answer, DnsPacket *p
         if (r < 0)
                 return r;
 
-        assert(r > 0);
-
         if (proposed_rrs_cmp(remote, r, our, size) > 0)
                 return 1;