From: Jeremy Allison <jra@samba.org>
Date: Wed, 10 Feb 2010 20:42:27 +0000 (-0800)
Subject: Revert "Change the default of "nmbd bind explicit broadcast" to "no""
X-Git-Tag: samba-3.6.0pre1~5478
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f2d7d9774e3dafc643567605dd1eef908b6ded1a;p=thirdparty%2Fsamba.git

Revert "Change the default of "nmbd bind explicit broadcast" to "no""

This reverts commit 84fba3c1bc962804259f201d465acfdf0cd3c6a8.

Now we have a "processed packet queue" in nmbd we can go back
to doing this by default.

Jeremy.
---

diff --git a/docs-xml/smbdotconf/misc/nmbdbindexplicitbroadcast.xml b/docs-xml/smbdotconf/misc/nmbdbindexplicitbroadcast.xml
index 8d2135b3ff7..3a44a69d543 100644
--- a/docs-xml/smbdotconf/misc/nmbdbindexplicitbroadcast.xml
+++ b/docs-xml/smbdotconf/misc/nmbdbindexplicitbroadcast.xml
@@ -7,10 +7,11 @@
 	<para>
 	This option causes <citerefentry><refentrytitle>nmbd</refentrytitle>
 	<manvolnum>8</manvolnum></citerefentry> to explicitly bind to the
-	broadcast address of the local subnets. This can be used to make nmbd
+	broadcast address of the local subnets. This is needed to make nmbd
 	work correctly in combination with the <smbconfoption name="socket address"/> option.
+	You should not need to unset this option.
 	</para>
 </description>
 
-<value type="default">no</value>
+<value type="default">yes</value>
 </samba:parameter>
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 3ada45e2ca7..8308e995660 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -4969,10 +4969,10 @@ static void init_globals(bool first_time_only)
 	string_set(&Globals.szPidDir, get_dyn_PIDDIR());
 	string_set(&Globals.szSocketAddress, "0.0.0.0");
 	/*
-	 * By default don't support explicit binding to broadcast
- 	 * addresses (until the nmbd "process twice" bug is fixed).
+	 * By default support explicit binding to broadcast
+ 	 * addresses.
  	 */
-	Globals.bNmbdBindExplicitBroadcast = false;
+	Globals.bNmbdBindExplicitBroadcast = true;
 
 	if (asprintf(&s, "Samba %s", samba_version_string()) < 0) {
 		smb_panic("init_globals: ENOMEM");