From: Björn Baumbach <bb@sernet.de>
Date: Fri, 9 Aug 2019 15:07:07 +0000 (+0200)
Subject: samba-tool group addmembers: add new option --object-types
X-Git-Tag: samba-4.12.0rc1~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f2e2579926e0bfcd8b150c33cd4784391426c5e6;p=thirdparty%2Fsamba.git

samba-tool group addmembers: add new option --object-types

With this option the admin can specify the object types of the group
members which will be added to the group. The search filter for the objects
will be created according to the types.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py
index 2e1db1371b4..6a8da402c47 100644
--- a/python/samba/netcmd/group.py
+++ b/python/samba/netcmd/group.py
@@ -229,12 +229,27 @@ Example2 shows how to add a single user account, User2, to the supergroup AD gro
     takes_options = [
         Option("-H", "--URL", help="LDB URL for database or target server", type=str,
                metavar="URL", dest="H"),
+        Option("--object-types",
+               help=("Comma separated list of object types.\n"
+                     "The types are used to filter the search for the "
+                     "specified members.\n"
+                     "Valid values are: user, group, computer, serviceaccount, "
+                     "contact and all.\n"
+                     "Default: user,group,computer"),
+               default="user,group,computer",
+               type=str),
     ]
 
     takes_args = ["groupname", "listofmembers"]
 
-    def run(self, groupname, listofmembers, credopts=None, sambaopts=None,
-            versionopts=None, H=None):
+    def run(self,
+            groupname,
+            listofmembers,
+            credopts=None,
+            sambaopts=None,
+            versionopts=None,
+            H=None,
+            object_types="user,group,computer"):
 
         lp = sambaopts.get_loadparm()
         creds = credopts.get_credentials(lp, fallback_machine=True)
@@ -243,8 +258,10 @@ Example2 shows how to add a single user account, User2, to the supergroup AD gro
             samdb = SamDB(url=H, session_info=system_session(),
                           credentials=creds, lp=lp)
             groupmembers = listofmembers.split(',')
+            group_member_types = object_types.split(',')
             samdb.add_remove_group_members(groupname, groupmembers,
-                                           add_members_operation=True)
+                                           add_members_operation=True,
+                                           member_types=group_member_types)
         except Exception as e:
             # FIXME: catch more specific exception
             raise CommandError('Failed to add members "%s" to group "%s"' % (