From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 24 Nov 2018 17:24:13 +0000 (+0000)
Subject: Explain what the connection pool is used for in v4.0.x
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f2e53b8d35f7910e7ba679d5b3aafc39e8fa570d;p=thirdparty%2Ffreeradius-server.git

Explain what the connection pool is used for in v4.0.x
---

diff --git a/raddb/mods-available/rest b/raddb/mods-available/rest
index 3ef2e9764bd..e025986a8e7 100644
--- a/raddb/mods-available/rest
+++ b/raddb/mods-available/rest
@@ -47,7 +47,7 @@ rest {
 	connect_uri = "http://127.0.0.1:9090/"
 
 	#
-	#  Proxy server used for connect requests.
+	#  Proxy server used for all outbound connections
 	#
 #	connect_proxy = "socks://127.0.0.1"
 
@@ -191,8 +191,17 @@ rest {
 	}
 
 	#
-	#  The connection pool is new for 3.0, and will be used in many
-	#  modules, for all kinds of connection-related activity.
+	#  This pool controls the number of handles available per-thread
+	#
+	#  Each handle represents a single HTTP request.
+	#  With HTTP <= 1.1, each request is bound to a single connection
+	#  so this pool, so these configuration items are useful for limiting
+	#  the number of outbound requests to the server.
+	#
+	#  With HTTP >= 2.0 with multiplexing enabled, multiple requests are
+	#  sent over a single HTTP connection, so the pool is more useful
+	#  for limiting the number of outstanding requests, and allowing for
+	#  handle reuse.
 	#
 	pool {
 		#  Connections to create during module instantiation.
@@ -200,10 +209,10 @@ rest {
 		#  connections during instantiation it will exit.
 		#  Set to 0 to allow the server to start without the
 		#  web service being available.
-		start = ${thread[pool].num_workers}
+		start = 20
 
 		#  Minimum number of connections to keep open
-		min = ${thread[pool].num_workers}
+		min = 1
 
 		#  Maximum number of connections
 		#
@@ -216,7 +225,7 @@ rest {
 		#
 		#  Setting 'max' to MORE than the number of threads means
 		#  that there are more connections than necessary.
-		max = ${thread[pool].num_workers}
+		max = 50
 
 		#  Spare connections to be left idle
 		#