From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 27 Sep 2022 14:50:36 +0000 (-0700)
Subject: gh-96478: Fix new test when run in refleak mode (GH-96615)
X-Git-Tag: v3.11.1~434
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f391b3c6ab7f9940c942535ebcfabf87eb122bf7;p=thirdparty%2FPython%2Fcpython.git

gh-96478: Fix new test when run in refleak mode (GH-96615)


./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136c69b4ed32bfb3096f926da098623a7072)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
---

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 7df7e3ceb680..0fce96b76e08 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -4379,19 +4379,19 @@ class OverloadTests(BaseTestCase):
 
         blah()
 
-    @patch("typing._overload_registry",
-        defaultdict(lambda: defaultdict(dict)))
     def test_overload_on_compiled_functions(self):
-        # The registry starts out empty:
-        self.assertEqual(typing._overload_registry, {})
-
-        # This should just not fail:
-        overload(sum)
-        overload(print)
-
-        # No overloads are recorded (but, it still has a side-effect):
-        self.assertEqual(typing.get_overloads(sum), [])
-        self.assertEqual(typing.get_overloads(print), [])
+        with patch("typing._overload_registry",
+                   defaultdict(lambda: defaultdict(dict))):
+            # The registry starts out empty:
+            self.assertEqual(typing._overload_registry, {})
+
+            # This should just not fail:
+            overload(sum)
+            overload(print)
+
+            # No overloads are recorded (but, it still has a side-effect):
+            self.assertEqual(typing.get_overloads(sum), [])
+            self.assertEqual(typing.get_overloads(print), [])
 
     def set_up_overloads(self):
         def blah():