From: Steve Holme <steve_holme@hotmail.com>
Date: Wed, 29 Oct 2014 14:14:17 +0000 (+0000)
Subject: sspi: Return CURLE_LOGIN_DENIED on AcquireCredentialsHandle() failure
X-Git-Tag: curl-7_39_0~60
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f3fc3d021d56f4842d4f4ce556ace446b8496e3f;p=thirdparty%2Fcurl.git

sspi: Return CURLE_LOGIN_DENIED on AcquireCredentialsHandle() failure

Return a more appropriate error, rather than CURLE_OUT_OF_MEMORY when
acquiring the credentials handle fails. This is then consistent with
the code prior to commit f7e24683c4 when log-in credentials were empty.
---

diff --git a/lib/curl_ntlm_msgs.c b/lib/curl_ntlm_msgs.c
index 92211aa97f..14ddc5f9ce 100644
--- a/lib/curl_ntlm_msgs.c
+++ b/lib/curl_ntlm_msgs.c
@@ -477,7 +477,7 @@ CURLcode Curl_ntlm_create_type1_message(const char *userp,
                                               ntlm->p_identity, NULL, NULL,
                                               ntlm->credentials, &expiry);
   if(status != SEC_E_OK)
-    return CURLE_OUT_OF_MEMORY;
+    return CURLE_LOGIN_DENIED;
 
   /* Allocate our new context handle */
   ntlm->context = malloc(sizeof(CtxtHandle));
diff --git a/lib/curl_sasl_sspi.c b/lib/curl_sasl_sspi.c
index 9aa84d77fe..21edcd65dc 100644
--- a/lib/curl_sasl_sspi.c
+++ b/lib/curl_sasl_sspi.c
@@ -210,7 +210,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
     Curl_safefree(resp);
     Curl_safefree(chlg);
 
-    return CURLE_OUT_OF_MEMORY;
+    return CURLE_LOGIN_DENIED;
   }
 
   /* Setup the challenge "input" security buffer */
@@ -367,7 +367,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
                                                 krb5->p_identity, NULL, NULL,
                                                 krb5->credentials, &expiry);
     if(status != SEC_E_OK)
-      return CURLE_OUT_OF_MEMORY;
+      return CURLE_LOGIN_DENIED;
 
     /* Allocate our new context handle */
     krb5->context = malloc(sizeof(CtxtHandle));