From: Daniel Wagner <wagi@kernel.org>
Date: Tue, 8 Apr 2025 15:29:10 +0000 (+0200)
Subject: nvmet-fc: put ref when assoc->del_work is already scheduled
X-Git-Tag: v6.6.89~33
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f444c139e820f8a09c3c76194e0f061009038659;p=thirdparty%2Fkernel%2Fstable.git

nvmet-fc: put ref when assoc->del_work is already scheduled

[ Upstream commit 70289ae5cac4d3a39575405aaf63330486cea030 ]

Do not leak the tgtport reference when the work is already scheduled.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 68ff9540e2d13..570c58d2b5a58 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1091,7 +1091,8 @@ static void
 nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)
 {
 	nvmet_fc_tgtport_get(assoc->tgtport);
-	queue_work(nvmet_wq, &assoc->del_work);
+	if (!queue_work(nvmet_wq, &assoc->del_work))
+		nvmet_fc_tgtport_put(assoc->tgtport);
 }
 
 static struct nvmet_fc_tgt_assoc *