From: XhmikosR Date: Sat, 21 Nov 2020 14:22:08 +0000 (+0200) Subject: Be consistent with Popper's name. (#32224) X-Git-Tag: v5.0.0-beta1~78 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f4457bca0274cbe02422434294e3c6a006da7750;p=thirdparty%2Fbootstrap.git Be consistent with Popper's name. (#32224) The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently. --- diff --git a/js/src/dropdown.js b/js/src/dropdown.js index c262997ce9..b9f5a4cd39 100644 --- a/js/src/dropdown.js +++ b/js/src/dropdown.js @@ -156,10 +156,10 @@ class Dropdown { return } - // Disable totally Popper.js for Dropdown in Navbar + // Totally disable Popper for Dropdowns in Navbar if (!this._inNavbar) { if (typeof Popper === 'undefined') { - throw new TypeError('Bootstrap\'s dropdowns require Popper.js (https://popper.js.org)') + throw new TypeError('Bootstrap\'s dropdowns require Popper (https://popper.js.org)') } let referenceElement = this._element @@ -329,7 +329,7 @@ class Dropdown { } } - // Disable Popper.js if we have a static display + // Disable Popper if we have a static display if (this._config.display === 'static') { popperConfig.modifiers.applyStyle = { enabled: false diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 7b115a69be..b2495a3e11 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -125,7 +125,7 @@ const TRIGGER_MANUAL = 'manual' class Tooltip { constructor(element, config) { if (typeof Popper === 'undefined') { - throw new TypeError('Bootstrap\'s tooltips require Popper.js (https://popper.js.org)') + throw new TypeError('Bootstrap\'s tooltips require Popper (https://popper.js.org)') } // private diff --git a/js/tests/unit/dropdown.spec.js b/js/tests/unit/dropdown.spec.js index b1a99e7e6b..f5f41636cd 100644 --- a/js/tests/unit/dropdown.spec.js +++ b/js/tests/unit/dropdown.spec.js @@ -100,7 +100,7 @@ describe('Dropdown', () => { expect(dropdown.toggle).toHaveBeenCalled() }) - it('should allow to pass config to popper.js with `popperConfig`', () => { + it('should allow to pass config to Popper with `popperConfig`', () => { fixtureEl.innerHTML = [ '
', ' ', @@ -841,7 +841,7 @@ describe('Dropdown', () => { expect(dropdown._element).toBeNull() }) - it('should dispose dropdown with popper.js', () => { + it('should dispose dropdown with Popper', () => { fixtureEl.innerHTML = [ '
', ' ', @@ -872,7 +872,7 @@ describe('Dropdown', () => { }) describe('update', () => { - it('should call popper.js and detect navbar on update', () => { + it('should call Popper and detect navbar on update', () => { fixtureEl.innerHTML = [ '
', ' ', @@ -1005,7 +1005,7 @@ describe('Dropdown', () => { btnDropdown.click() }) - it('should not use popper.js in navbar', done => { + it('should not use Popper in navbar', done => { fixtureEl.innerHTML = [ '