From: Mark Andrews <marka@isc.org>
Date: Thu, 25 Aug 2011 06:28:11 +0000 (+0000)
Subject: silence 'Dereference of undefined pointer value' by assigning to 'sorted' sequentiall... 
X-Git-Tag: v9.9.0a2~1^2~126
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f4a4f6945ecd565c1e86b599b8a353a2921803d4;p=thirdparty%2Fbind9.git

silence 'Dereference of undefined pointer value' by assigning to 'sorted' sequentially from zero
---

diff --git a/lib/dns/rdataset.c b/lib/dns/rdataset.c
index e6fa634cd1a..c17f661fcad 100644
--- a/lib/dns/rdataset.c
+++ b/lib/dns/rdataset.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rdataset.c,v 1.90 2011/06/08 22:13:50 each Exp $ */
+/* $Id: rdataset.c,v 1.91 2011/08/25 06:28:11 marka Exp $ */
 
 /*! \file */
 
@@ -442,11 +442,11 @@ towiresorted(dns_rdataset_t *rdataset, const dns_name_t *owner_name,
 			j = val % count;
 			for (i = 0; i < count; i++) {
 				if (order != NULL)
-					sorted[j].key = (*order)(&shuffled[i],
+					sorted[i].key = (*order)(&shuffled[j],
 								 order_arg);
 				else
-					sorted[j].key = 0; /* Unused */
-				sorted[j].rdata = &shuffled[i];
+					sorted[i].key = 0; /* Unused */
+				sorted[i].rdata = &shuffled[j];
 				j++;
 				if (j == count)
 					j = 0; /* Wrap around. */